TYP: Type annotations overhaul, episode 2#288
Merged
lucascolley merged 24 commits intodata-apis:mainfrom Apr 17, 2025
Merged
Conversation
crusaderky
reviewed
Mar 28, 2025
crusaderky
reviewed
Mar 28, 2025
crusaderky
reviewed
Mar 28, 2025
Member
Author
|
I'm not really sure what's causing these test failures here 🤔 |
Contributor
They're in main too |
This was referenced Mar 29, 2025
jorenham
force-pushed
the
typing-overhaul-episode-2
branch
from
37b9c7b to
a522dbc
Compare
Co-authored-by: crusaderky <crusaderky@gmail.com>
Member
|
I'll try to take a cursory look at this before the meeting today |
lucascolley
approved these changes
Apr 17, 2025
Member
lucascolley
left a comment
lucascolley
left a comment
There was a problem hiding this comment.
thanks Joren, this looks great! I looked through the whole diff. Approval pending discussion of builtin subclasses in the community meeting. Some comments but nothing major
Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
Co-authored-by: lucascolley <lucas.colley8@gmail.com>
Member
|
all good from the community meeting 👍 |
This was referenced Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP in progress, but feel free to say whatever you feel like saying about the stuff I've already touched at this point.
_internalcommon/*numpy__init___aliases_info_typingfftlinalgtorch.*dask.array.*(except for.fft)Because
cupyhas nopy.typed, and is too dynamic for pyright to analyse, it's pretty much impossible to annotatecupy.*at the moment.I decided to skip
torchfor now; this PR is big enough already.relevant info about
bool | int | float | complex:#291 (comment)